Fix Windows CI #289
Merged
Fix Windows CI #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Oct 29, 2024
|
And great timing, @FranzBusch just added the windows CI pipeline. Let's see what this looks like. |
|
The tests build and run now but we have numerous failures. |
|
Yeah, we knew that we had CI failures. Paul was only trying to get the build to pass, so we can merge this as-is. WE'll need to fix the Windows CI failures, of course, but at least we now have a CI system that is capable of locking in the win. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a platform check to
scryptwhich replacessysconfwith its Windows counterpart to make Windows CI pass